Don't error on SSH_AGAIN in discard_output
#45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsfarseen
changed the title
SSH_AGAIN in discard_output
As per the docs of `ssh_channel_read_timeout`: > The number of bytes read, 0 on end of file or SSH_ERROR > on error. In nonblocking mode it can return 0 if no data > is available or SSH_AGAIN. SSH_AGAIN is -2. So it was hitting the `nbytes < 0` branch and exiting with an error. Changed it to have the same behaviour as `nbytes == 0` Reference: https://api.libssh.org/master/group__libssh__channel.html#ga2f4e02cb3b3adbc30a534623164068fd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the docs of
ssh_channel_read_timeout:SSH_AGAIN is -2. So it was hitting the
nbytes < 0branch and exiting with an error. Changed it to have the same behaviour asnbytes == 0Reference: https://api.libssh.org/master/group__libssh__channel.html#ga2f4e02cb3b3adbc30a534623164068fd